hrynco/hrynco-notification-service
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Compare commits

base: hrynco/hrynco-notification-service:dfa097eb43ff9d326f02c6b4371c09e2251f8046
Branches Tags
hrynco/hrynco-notification-service:IT-628 hrynco/hrynco-notification-service:main hrynco/hrynco-notification-service:development hrynco/hrynco-notification-service:use-hrynco-ef-packages
...
compare: hrynco/hrynco-notification-service:ab042c7617863261e66be98db5dfd253cb19d8b0
Branches Tags
hrynco/hrynco-notification-service:main hrynco/hrynco-notification-service:development hrynco/hrynco-notification-service:use-hrynco-ef-packages hrynco/hrynco-notification-service:IT-628

2 Commits
dfa097eb43 ... ab042c7617

Author SHA1 Message Date
agrynco ab042c7617 Merge pull request 'refactor: improve UpdateAsync in EmailTemplateRepository for better entity handling' (#7) from development into main 
Reviewed-on: #7
 2026-05-13 03:40:31 +03:00
Anatolii Grynchuk 0861e18cec refactor: improve UpdateAsync in EmailTemplateRepository for better entity handling 
- Add null check and fetch entity before updating fields.
- Replace the direct property assignment with detailed updates.
- Ensure changes are saved using SaveChangesAsync.
 2026-05-13 03:39:44 +03:00
1 changed files with 20 additions and 4 deletions
Expand all files Collapse all files
HrynCo.NotificationService.DAL.EF/Repositories/EmailTemplateRepository.cs
+20 -4
View File
@@ -46,11 +46,27 @@ internal sealed class EmailTemplateRepository
return EfRepository.AddAsync(MapToEntity(EmailTemplate)); return EfRepository.AddAsync(MapToEntity(EmailTemplate));
} }
public Task UpdateAsync(EmailTemplate EmailTemplate, CancellationToken ct = default) public async Task UpdateAsync(EmailTemplate EmailTemplate, CancellationToken ct = default)
{ {
EmailTemplateEntity entity = MapToEntity(EmailTemplate); EmailTemplateEntity? entity = await EfRepository.Get()
entity.Updated = DateTimeOffset.UtcNow; .FirstOrDefaultAsync(x => x.Id == EmailTemplate.Id, ct);
return EfRepository.UpdateAsync(entity);
if (entity is null)
{
return;
}
entity.ServiceName = EmailTemplate.ServiceName;
entity.Key = EmailTemplate.Key;
entity.LanguageCode = EmailTemplate.LanguageCode;
entity.Subject = EmailTemplate.Subject;
entity.HtmlBody = EmailTemplate.HtmlBody;
entity.TextBody = EmailTemplate.TextBody;
entity.Variables = EmailTemplate.Variables
.Select(v => new EmailTemplateVariableData { Name = v.Name, Required = v.Required })
.ToList();
await EfRepository.SaveChangesAsync();
} }
public async Task DeleteAsync(EmailTemplate EmailTemplate, CancellationToken ct = default) public async Task DeleteAsync(EmailTemplate EmailTemplate, CancellationToken ct = default)